Skip to content

Update filterObject docs to reference pickBy #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2018
Merged

Conversation

cooperka
Copy link
Contributor

This is clearly an area of confusion -- see this question as an example. Hopefully this helps.

@jsf-clabot
Copy link

jsf-clabot commented Jul 10, 2018

CLA assistant check
All committers have signed the CLA.

filterObject.js Outdated
@@ -3,12 +3,14 @@
* `predicate` returns truthy for. The predicate is invoked with three
* arguments: (value, key, object).
*
* **Note:** If you want an object in return, consider `pickBy`.
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cooperka Could you reword

If you want an object in return, consider pickBy.

@cooperka
Copy link
Contributor Author

@jdalton done!

@jdalton jdalton merged commit 4851183 into lodash:master Jul 10, 2018
@jdalton
Copy link
Member

jdalton commented Jul 10, 2018

Thank you!

@lock
Copy link

lock bot commented Jul 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy