Skip to content

Use native filter instead of custom one where possible #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

blikblum
Copy link
Contributor

This flattens the dependency tree making the size cost of some modules smaller

BTW: not related to the changes but xorBy and xorWith seems buggy (not tested) since is including the iteratee in the filtered array

@jdalton jdalton merged commit 238e763 into lodash:master Dec 11, 2018
@jdalton
Copy link
Member

jdalton commented Dec 11, 2018

This is great @blikblum! Thank you!

@blikblum blikblum deleted the cleanup-filter branch December 11, 2018 16:47
@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy