Skip to content

lint files #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2019
Merged

lint files #4416

merged 3 commits into from
Aug 17, 2019

Conversation

phapdinh
Copy link
Contributor

This fixes issue issue #4415

@jsf-clabot
Copy link

jsf-clabot commented Aug 17, 2019

CLA assistant check
All committers have signed the CLA.

.eslintrc.js Outdated
@@ -83,7 +83,7 @@ module.exports = {
'requireReturnForObjectLiteral': false
}],

'arrow-parens': ['error', 'always'],
// 'arrow-parens': ['error', 'always'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented out this rule because sometimes arrow functions if they have only one parameter don't need parens

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to enable. I want to be consistent and always use parens.

Copy link
Contributor Author

@phapdinh phapdinh Aug 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdalton I have added back this rule and now npm run style passes

@jdalton jdalton mentioned this pull request Aug 17, 2019
@jdalton jdalton added the bug label Aug 17, 2019
@jdalton
Copy link
Member

jdalton commented Aug 17, 2019

Thank you @phapdinh!

@jdalton jdalton merged commit 15e1557 into lodash:master Aug 17, 2019
@jdalton jdalton added issue bankruptcy Closing the issue/PR to start fresh and removed issue bankruptcy Closing the issue/PR to start fresh labels Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy