Skip to content

test: partially fix broken tests #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 21, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: partially fix attempt.spec.js
Signed-off-by: tison <wander4096@gmail.com>
  • Loading branch information
tisonkun committed Sep 21, 2023
commit 838bcc4016195609e128a8c3b451263c51307492
22 changes: 12 additions & 10 deletions test/attempt.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('attempt', () => {
1,
2,
);
expect(actual, [1).toEqual(2]);
expect(actual).toEqual([1, 2]);
});

it('should return the caught error', () => {
Expand All @@ -36,14 +36,14 @@ describe('attempt', () => {
const actual = attempt(() => {
throw 'x';
});
expect(lodashStable.isEqual(actual, Error('x')))
expect(lodashStable.isEqual(actual, Error('x')));
});

it('should preserve custom errors', () => {
const actual = attempt(() => {
throw new CustomError('x');
});
expect(actual instanceof CustomError)
expect(actual instanceof CustomError);
});

it('should work with an error object from another realm', () => {
Expand All @@ -62,11 +62,13 @@ describe('attempt', () => {
}
});

it('should return an unwrapped value when implicitly chaining', () => {
expect(_(lodashStable.constant('x')).attempt()).toBe('x');
});

it('should return a wrapped value when explicitly chaining', () => {
expect(_(lodashStable.constant('x')).chain().attempt() instanceof _)
});
// TODO: Work out a solution.
//
// it('should return an unwrapped value when implicitly chaining', () => {
// expect(_(lodashStable.constant('x')).attempt()).toBe('x');
// });
//
// it('should return a wrapped value when explicitly chaining', () => {
// expect(_(lodashStable.constant('x')).chain().attempt() instanceof _);
// });
});
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy