Skip to content

Added double click to almost all components #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'dev' into doubleClick_event_component
  • Loading branch information
kamal-qureshi committed Jun 13, 2025
commit 5c18bfc123c44575db44627e59e24a7d6d7e6b4e
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ export const ColumnLink = React.memo(({ disabled, label, onClick, onEvent }: { d
ComponentClickHandler({onEvent})();
}
}, [disabled, onEvent]);
// if (disabled) return;
// onClick?.();
// // onEvent?.("click");
// }, [disabled, onClick, onEvent]);

return (
<StyledLink
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,16 @@ const MenuItem = React.memo(({ option, index, onMainEvent }: { option: any; inde
onMainEvent?.(event);
};
ComponentClickHandler({onEvent: combinedHandler})();
// if (option.onClick) {
// option.onClick();
// }
// // if (option.onEvent) {
// // option.onEvent("click");
// // }
// // Trigger the main component's event handler
// if (onMainEvent) {
// onMainEvent("click");
// }
}
}, [option.disabled, option.onEvent, onMainEvent]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ const ButtonStyled = React.memo(({ props }: { props: ToViewReturn<RecordConstruc
const handleClick = useCallback((e: React.MouseEvent) => {
ComponentClickHandler({onEvent: props.onEvent})
}, [props.onEvent]);
// props.onClick?.();
// // props.onEvent?.("click");
// }, [props.onClick, props.onEvent]);

const buttonStyle = useMemo(() => ({
margin: 0,
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy