Skip to content

Nav Layout Fixes/Updates #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 20, 2023
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,13 @@ export class LayoutMenuItemComp extends MultiBaseComp<ChildrenType> {
}

override getPropertyView(): ReactNode {
const isLeaf = this.children.items.getView().length === 0;
return (
<>
{isLeaf &&
this.children.action.propertyView({
onAppChange: (label) => {
label && this.children.label.dispatchChangeValueAction(label);
},
})}
{this.children.action.propertyView({
onAppChange: (label) => {
label && this.children.label.dispatchChangeValueAction(label);
},
})}
{this.children.label.propertyView({ label: trans("label") })}
{this.children.icon.propertyView({
label: trans("icon"),
Expand Down Expand Up @@ -98,12 +96,17 @@ const LayoutMenuItemCompMigrate = migrateOldData(LayoutMenuItemComp, (oldData: a
export class LayoutMenuItemListComp extends list(LayoutMenuItemCompMigrate) {
addItem(value?: any) {
const data = this.getView();

this.dispatch(
this.pushAction(
value || {
label: trans("menuItem") + " " + (data.length + 1),
itemKey: genRandomKey(),
}
value
? {
...value,
itemKey: value.itemKey || genRandomKey(),
} : {
label: trans("menuItem") + " " + (data.length + 1),
itemKey: genRandomKey(),
}
)
);
}
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy