Skip to content

fix(xml): add missing 's' to '#instructions' in clone/doc #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

fix(xml): add missing 's' to '#instructions' in clone/doc #102

merged 1 commit into from
May 30, 2025

Conversation

lowlighter
Copy link
Owner

While taking a look at #96, noticed that doc and clone method referenced #instruction but it is actual defined as plural #instructions in the code

libs/xml/parse.ts

Lines 172 to 176 in 2969d11

// XML processing instruction
case Token.XMLInstruction: {
const [name, ...raw] = value.split(" ")
const instruction = Object.assign(xml_node(name, { parent: xml }), xml_attributes(raw.join(" ")))
xml["#instructions"] ??= {}

@lowlighter lowlighter merged commit 3e3faaf into main May 30, 2025
76 checks passed
@lowlighter lowlighter deleted the fix-missing-s-instruction branch May 30, 2025 17:17
@lowlighter lowlighter mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lowlighter
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy