Adding middleware call in host queue writes #4337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prateek
reviewed
Apr 28, 2025
src/dbnode/client/host_queue.go
Outdated
| @@ -674,7 +677,7 @@ func (q *queue) asyncWrite( | |||
| } | |||
|
|
|||
| ctx, _ := thrift.NewContext(q.opts.WriteRequestTimeout()) | |||
| err = client.WriteBatchRaw(ctx, req) | |||
| err = q.middleware(client).WriteBatchRaw(ctx, req) | |||
There was a problem hiding this comment.
simplify this middleware wrapping to be done at construction time, instead of each request
prateek
reviewed
May 1, 2025
src/dbnode/client/host_queue.go
Outdated
| @@ -92,6 +93,29 @@ func newHostQueue( | |||
| iOpts = iOpts.SetMetricsScope(scope) | |||
| opts = opts.SetInstrumentOptions(iOpts.SetMetricsScope(scope)) | |||
|
|
|||
| // Create circuit breaker middleware | |||
| cbMiddleware, err := middleware.New( | |||
There was a problem hiding this comment.
do you want to add support for a no-op middleware somehow?
There was a problem hiding this comment.
you added the type but it's not used anywhere. should we do something like if circuitbreaker not enabled use the noop else current path?
prateek
reviewed
May 1, 2025
prateek
reviewed
May 6, 2025
prateek
reviewed
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR uses circuit breaker middleware in M3DB client write calls.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: