Skip to content

adding initial code for StratifiedShuffleSplit #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

adding initial code for StratifiedShuffleSplit #243

wants to merge 9 commits into from

Conversation

VariableVasasMT
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    implementation for StratifiedShuffleSplit

JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
@JasonShin
Copy link
Member

There is a test failure due to the doc processor cannot handle certain type. Could you please take a look at it? Let me know if it's too hard.

@JasonShin JasonShin closed this Jun 13, 2019
@JasonShin JasonShin reopened this Jun 13, 2019
@VariableVasasMT
Copy link
Collaborator Author

sure will do

JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
@JasonShin
Copy link
Member

Also, could you make sure these things?

  1. Export StratifiedShuffleSplit in index.ts (check model_selection/index.ts) so the users can actually use it
  2. add an integration test
  3. Please add unit tests to ensure 100% coverage and all the behaviours for this code
  4. You need to add doc strings (check other APIs) so the doc processor can actually pick it up and generate documentation.

JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
JasonShin
JasonShin reviewed Jun 13, 2019
View reviewed changes
@VariableVasasMT
added following
f4dded7 
  * added arraySplit
  * moved forward in stratifiedShuffleSplit
@VariableVasasMT
added following:
6dd1519 
 * added random class
 * adding StratifiedShuffleSplit
 * adding approximateMode, cumSum, countBin in tensors.ts
@VariableVasasMT
new random number implemented
8ce44fd
@VariableVasasMT VariableVasasMT mentioned this pull request Sep 23, 2019
Closed
@VariableVasasMT
Copy link
Collaborator Author

Also, could you make sure these things?

1. Export `StratifiedShuffleSplit` in `index.ts` (check model_selection/index.ts) so the users can actually use it

2. add an integration test

3. Please add unit tests to ensure 100% coverage and all the behaviours for this code

4. You need to add doc strings (check other APIs) so the doc processor can actually pick it up and generate documentation.

fixed

@VariableVasasMT
Copy link
Collaborator Author

@JasonShin please review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonShin JasonShin JasonShin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VariableVasasMT @JasonShin
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy