Skip to content

Fix Python testing warnings #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Python testing warnings #1233

wants to merge 1 commit into from

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 29, 2025 •
edited
Loading

Change Summary

This small PR migrates from unittest.assertEquals to unittest.assertEqual which is deprecated from Python2.7:

DeprecationWarning: Please use assertEqual instead.

Related Jira Ticket

Checklist

  • Tests have been added for changes
  • Documentation has been updated
  • Breaking changes are clearly identified
  • Python client changes linked or N/A

For new field types:

  • Tests cover score modifier usage of this new type
  • Test indexes updated to cover the new type for all APIs (add docs, search, partial update, etc.)

@emmanuel-ferdman
Fix Python testing warnings
e7deb42 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@farshidz farshidz closed this Jun 2, 2025
@emmanuel-ferdman
Copy link
Contributor Author

@farshidz hi, mind to explain?

@farshidz
Copy link
Collaborator

farshidz commented Jun 2, 2025

@emmanuel-ferdman PRs can't consist solely of deprecation warning fixes.

@emmanuel-ferdman
Copy link
Contributor Author

@farshidz I believe commits should focus on a single goal, and fixing deprecation warnings improves future compatibility and code health, even if the PR is small. But sure, just wanted to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmanuel-ferdman @farshidz
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy