Reduce pause time in interactive timer test #30271
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c72b054 to
3208831
Compare
greglucas
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
This is fine as an incremental update since you note GTK isn't being tested here.
The interactive timers are currently not correct IMO and we need to update them to make sure the timers don't overrun their pause duration. This test is completely reworked in #29062 but that is also failing on the appveyor runs with the GTK backends, I assume because the underlying OS there is causing that timer to be even slower and not get as many triggers. Feel free to review/comment on that PR if you have suggestions there too.
jkseppan
approved these changes
Jul 9, 2025
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Since the Appveyor run is timing out, I went hunting for some low hanging fruit to speed up the tests. From the slower tests, this seemed like an obvious target as each run of the test is taking ~10 seconds. This seems to work fine.
Since gtk3cairo is disabled in this test, the comment doesn't seem relevant any more.
PR checklist