Migrate to Pybind11 v3 #30291
Draft
Migrate to Pybind11 v3 #30291
+85
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of pybind/pybind11#5212, pybind11 now uses `numpy.typing.NDArray` instead of `numpy.ndarray`, and as of pybind/pybind11#5580, it changed the name of the internal wrapper that Sphinx sees. Since we already ignore `numpy.float64` missing references for the same method, add the new name and new class to ignores as well.
And drop the manual wrapper to emulate it.
This is the recommended, but not-yet-default, holder for C++ classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This was just released, so we probably don't want to make a hard cut-off here, but this is just a check to see how the new options work out without any attempt to maintain backwards-compatibility.
PR checklist