Skip to content

CI: Harden GHA configuration #30332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

CI: Harden GHA configuration #30332

merged 2 commits into from
Jul 24, 2025

Conversation

tacaswell
Copy link
Member

Apply recommended hardening steps including:

  • pinning to a SHA any actions used
  • not persisting the read token on checkout
  • setting the default permissions
  • adding a depandabot file for GHA

- Prevents checkout premissions from leaking
@QuLogic
Copy link
Member

QuLogic commented Jul 18, 2025

I've been meaning to do this, but could you rename the workflow to linting.yml? It now has pre-commit in it, so it's not really just reviewdog, and linting seems a better name.

@tacaswell
Copy link
Member Author

This does not address the permissions that are needed for the stale / stale-tidy workflows.

@tacaswell tacaswell added this to the v3.11.0 milestone Jul 24, 2025
@ksunden ksunden merged commit b25ff80 into matplotlib:main Jul 24, 2025
38 of 40 checks passed
@tacaswell tacaswell deleted the harden_gha branch July 24, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy