Skip to content

Multiple matrices in linear combination #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Jan 8, 2024
Merged

Multiple matrices in linear combination #75

merged 59 commits into from
Jan 8, 2024

Conversation

jarlebring
Copy link
Collaborator

@jarlebring jarlebring commented Jan 4, 2024 •
edited
Loading

Here is a suggestion for #73 . Vectors instead of Tuples. Still WIP.

Modifications needed:

  • Change graph_degopt to use multiple add_lincombs instead of add_sum
  • remove topo_degopt
  • fix merge
  • fix get_degopt_crefs
  • fix exp_degopt
  • Code generation Julia
    • remove functionality wrt dot fusion (removes a lot of code)
    • check single term lincomb
  • Code generation Matlab
  • Code generation BLAS:
    • bi-graph functionality graph_bigraph
    • BLAS preprocessing to bigraph
  • graph compression (several functions additional tests)
    • compress_zero_coeff
    • compress_passthrough
    • compress_trivial
    • compress_redundant
  • double check merge_graphs
  • check export
  • add functionality on import
  • add tests for single term lincomb

@jarlebring
Copy link
Collaborator Author

The "old" tests now pass.

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6d103c0) 93.72% compared to head (8de88e9) 91.05%.

Files Patch % Lines
src/generators/bigraph.jl 80.76% 5 Missing ⚠️
src/compress_graph.jl 97.67% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   93.72%   91.05%   -2.68%     
==========================================
  Files          30       30              
  Lines        2646     2582      -64     
==========================================
- Hits         2480     2351     -129     
- Misses        166      231      +65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jarlebring
bugfix in LangJulia constructors
fc6ad4b
@jarlebring
extract_sum no longer needed
ba939cf
@jarlebring
multilincomb not needed
02b71c0
@jarlebring
rm multilincomb
3617f08
@jarlebring
clean up zero coeff compress for mult lincomb
6e49a99
@jarlebring
clean up zero coeff compress for mult lincomb
02f00a1
@jarlebring
clean up compress_passthrough
f80bca0
@jarlebring
fix compress_graph_trivial
7fa8d55
@jarlebring
cond println typo
5a79c89
@jarlebring
improve redundant tests
1b3fa79
@jarlebring
improve trivial test
d37441b
@jarlebring
output cleaning no longer needed
4073d6b
@jarlebring
improve test coverage
dcdf3cf
@jarlebring
test also single term i julialang
9f9d8b1
@jarlebring
test also multiterms
40a9400
@jarlebring
import with multiterm
66a6744
@jarlebring
multiple outputs fix
9c178f7
@jarlebring
multiple outputs fix
bb33cc7
@jarlebring
adding a convert bigraph mostly for BLAS-support
1caf58e
@jarlebring
main_output no longer supported
1d76e8e
@jarlebring
fix import output test statements
e402bfd
@jarlebring
BLAS only supports bigraph
8de88e9
@jarlebring
single term graph_op test
2b59820
@jarlebring
remove debug output
3d0ed78
@jarlebring
more graph op test updates
54e78d8
@jarlebring
improve test coverage bigraph
f08eeb5
@jarlebring
old code. functionality elsewhere
6a7c682
@jarlebring
Copy link
Collaborator Author

This seems pretty ready. BLAS-tests done separately. Coverage okay. I will merge this in a couple of days unless there are other comments.

@jarlebring jarlebring merged commit a8ec53a into main Jan 8, 2024
@jarlebring jarlebring deleted the multilincomb_refactor branch January 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarlebring @codecov-commenter
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy