Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Proposal for Triage Role [resolves #1561] #1621

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Proposal for Triage Role [resolves #1561] #1621

wants to merge 7 commits into from
+49 −0

Conversation

franciscojavierarceo
Copy link
Contributor

@franciscojavierarceo franciscojavierarceo commented Mar 13, 2025 •
edited
Loading

What does this PR do?

This RFC outlines a proposal for a Triage role to help reduce the load on the current maintainers. Note that this does not propose any individual triage members and leaves that at the discretion of the maintainers.

Closes #1561

Implementation

We tested this functionality using the @feast-dev repository and have provided screenshots outlining how to make this change using @nathan-weinberg's handle.

Step 1: Select Repository Settings triage-role-config-1

Step 2: Invite Outside Collaborator triage-role-config-2

Step 3: Select Triage Role triage-role-config-3

Step 4: User Receives Triage Role Notification triage-role-config-4

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Mar 13, 2025
booxter
booxter approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@booxter booxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we really have to include screenshots for this in git, but in general, +1 for introducing the role.

@franciscojavierarceo
Copy link
Contributor Author

I don't know if we really have to include screenshots for this in git, but in general, +1 for introducing the role.

I figured it'd make it easier than having to look up how to do it and what not but I can definitely delete them before merging this.

@franciscojavierarceo
Adding note about process for nomination
7eb7c94 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@franciscojavierarceo franciscojavierarceo force-pushed the triage-proposal branch 3 times, most recently from f6c94d7 to 7eb7c94 Compare March 14, 2025 00:17
@franciscojavierarceo
Removing example section
9ba2e17 
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
nathan-weinberg
nathan-weinberg approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting this @franciscojavierarceo !

@franciscojavierarceo franciscojavierarceo changed the title feat: Proposal for Triage Role (resolve https://github.com/meta-llama/llama-stack/discussions/1561) feat: Proposal for Triage Role [resolves #1561] Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booxter booxter booxter approved these changes

@cdoern cdoern cdoern approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

@ashwinb ashwinb Awaiting requested review from ashwinb ashwinb is a code owner

@yanxi0830 yanxi0830 Awaiting requested review from yanxi0830 yanxi0830 is a code owner

@hardikjshah hardikjshah Awaiting requested review from hardikjshah hardikjshah is a code owner

@dltn dltn Awaiting requested review from dltn dltn is a code owner

@raghotham raghotham Awaiting requested review from raghotham raghotham is a code owner

@dineshyv dineshyv Awaiting requested review from dineshyv dineshyv is a code owner

@vladimirivic vladimirivic Awaiting requested review from vladimirivic vladimirivic is a code owner

@sixianyi0721 sixianyi0721 Awaiting requested review from sixianyi0721 sixianyi0721 is a code owner

@ehhuang ehhuang Awaiting requested review from ehhuang ehhuang is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@SLR722 SLR722 Awaiting requested review from SLR722 SLR722 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@franciscojavierarceo @booxter @cdoern @nathan-weinberg @facebook-github-bot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy