Skip to content

tests/extmod/asyncio_iterator_event.py: Use format instead of f-string. #17550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

tests/extmod/asyncio_iterator_event.py: Use format instead of f-string. #17550

merged 1 commit into from
Jul 12, 2025
+1 −1

Conversation

dpgeorge
Copy link
Member

Summary

Some targets don't have f-strings enabled, so try not to use them in tests. Rather use str.format which is more portable.

Testing

Tested on SEEED_XIAO_SAMD21. Before this change the test would fail with SyntaxError. Now it skips.

@dpgeorge dpgeorge added the tests Relates to tests/ directory in source label Jun 23, 2025
@dpgeorge dpgeorge force-pushed the tests-extmod-asyncio-iterator-event-remove-fstring branch from 8f04901 to a28aa32 Compare June 23, 2025 03:17
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (499bedf) to head (908f938).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #17550   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         171      171           
  Lines       22192    22192           
=======================================
  Hits        21847    21847           
  Misses        345      345

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpgeorge
tests/extmod/asyncio_iterator_event.py: Use format instead of f-string.
908f938 
Some targets don't have f-strings enabled, so try not to use them in tests.
Rather, use `str.format`, which is more portable.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tests-extmod-asyncio-iterator-event-remove-fstring branch from a28aa32 to 908f938 Compare July 12, 2025 12:38
@dpgeorge dpgeorge merged commit 908f938 into micropython:master Jul 12, 2025
28 of 29 checks passed
@dpgeorge dpgeorge deleted the tests-extmod-asyncio-iterator-event-remove-fstring branch July 12, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Relates to tests/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgeorge
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy