Merge pull request #146 from jakebailey/bloomberg-isolated-declarations-errors-fix-3

dragomirtitian · web-flow · commit ee7a87240778 · 2024-04-19T22:11:28.000+01:00
Make isEntityNameVisible have the same parameter order
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -1484,7 +1484,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
     var emitResolver = createResolver();
     var nodeBuilder = createNodeBuilder();
     var syntacticNodeBuilder = createSyntacticTypeNodeBuilder(compilerOptions, {
-        isEntityNameVisible: (enclosingDeclaration, entityName, shouldComputeAliasToMakeVisible) => isEntityNameVisible(entityName, enclosingDeclaration, shouldComputeAliasToMakeVisible),
+        isEntityNameVisible,
         isExpandoFunctionDeclaration,
         isNonNarrowedBindableName,
         getAllAccessorDeclarations: getAllAccessorDeclarationsForDeclaration,
diff --git a/src/compiler/expressionToTypeNode.ts b/src/compiler/expressionToTypeNode.ts
@@ -372,7 +372,7 @@ export function createSyntacticTypeNodeBuilder(options: CompilerOptions, resolve
                     context.tracker.reportInferenceFallback(prop.name);
                 }
                 else if (isEntityNameExpression(prop.name.expression)) {
-                    const visibilityResult = resolver.isEntityNameVisible(context.enclosingDeclaration!, prop.name.expression, /*shouldComputeAliasToMakeVisible*/ false);
+                    const visibilityResult = resolver.isEntityNameVisible(prop.name.expression, context.enclosingDeclaration!, /*shouldComputeAliasToMakeVisible*/ false);
                     if (visibilityResult.accessibility !== SymbolAccessibility.Accessible) {
                         context.tracker.reportInferenceFallback(prop.name);
                     }
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -10250,6 +10250,6 @@ export interface SyntacticTypeNodeBuilderResolver {
     isNonNarrowedBindableName(name: ComputedPropertyName): boolean;
     isExpandoFunctionDeclaration(name: FunctionDeclaration | VariableDeclaration): boolean;
     getAllAccessorDeclarations(declaration: AccessorDeclaration): AllAccessorDeclarations;
-    isEntityNameVisible(enclosingDeclaration: Node, entityName: EntityNameOrEntityNameExpression, shouldComputeAliasToMakeVisible?: boolean): SymbolVisibilityResult;
+    isEntityNameVisible(entityName: EntityNameOrEntityNameExpression, enclosingDeclaration: Node, shouldComputeAliasToMakeVisible?: boolean): SymbolVisibilityResult;
     requiresAddingImplicitUndefined(parameter: ParameterDeclaration | JSDocParameterTag): boolean;
 }

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ export function createSyntacticTypeNodeBuilder(options: CompilerOptions, resolve`
`372`	`372`	`context.tracker.reportInferenceFallback(prop.name);`
`373`	`373`	`}`
`374`	`374`	`else if (isEntityNameExpression(prop.name.expression)) {`
`375`		`- const visibilityResult = resolver.isEntityNameVisible(context.enclosingDeclaration!, prop.name.expression, /shouldComputeAliasToMakeVisible/ false);`
	`375`	`+ const visibilityResult = resolver.isEntityNameVisible(prop.name.expression, context.enclosingDeclaration!, /shouldComputeAliasToMakeVisible/ false);`
`376`	`376`	`if (visibilityResult.accessibility !== SymbolAccessibility.Accessible) {`
`377`	`377`	`context.tracker.reportInferenceFallback(prop.name);`
`378`	`378`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10250,6 +10250,6 @@ export interface SyntacticTypeNodeBuilderResolver {`
`10250`	`10250`	`isNonNarrowedBindableName(name: ComputedPropertyName): boolean;`
`10251`	`10251`	`isExpandoFunctionDeclaration(name: FunctionDeclaration \| VariableDeclaration): boolean;`
`10252`	`10252`	`getAllAccessorDeclarations(declaration: AccessorDeclaration): AllAccessorDeclarations;`
`10253`		`- isEntityNameVisible(enclosingDeclaration: Node, entityName: EntityNameOrEntityNameExpression, shouldComputeAliasToMakeVisible?: boolean): SymbolVisibilityResult;`
	`10253`	`+ isEntityNameVisible(entityName: EntityNameOrEntityNameExpression, enclosingDeclaration: Node, shouldComputeAliasToMakeVisible?: boolean): SymbolVisibilityResult;`
`10254`	`10254`	`requiresAddingImplicitUndefined(parameter: ParameterDeclaration \| JSDocParameterTag): boolean;`
`10255`	`10255`	`}`