Error for missing module flag is now in createProgram #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4679,12 +4677,6 @@ module ts { | |||
| return false; | |||
| } | |||
|
|
|||
| function checkDeclarationModifiers(node: Node) { | |||
There was a problem hiding this comment.
Shouldn't we have been checking for other modifiers here?
There was a problem hiding this comment.
It used to be primarily for the 'declare' modifier. I have gradually pulled things out of this function without changing its name, and this was the only thing left.
|
After changes, LGTM. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to try to emit if the --module flag was not specified. So I have moved this logic to createProgram, whose errors prevent emit.
I have also changed the way we track external module-hood of a file. Instead of having a flag NodeFlags.ExternalModule, there is now a property on the SourceFile called externalModuleIndicator. This is the first node in the file that causes the file to be an external module. When we check for the missing module flag, we will error on this node.
I've also added a function getErrorSpanForNode, which is currently empty. But it is supposed to take a node, and return the best error span to give an error on that node.