Skip to content

Contextual typing of partially annotated signatures #11673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2016
Merged

Contextual typing of partially annotated signatures #11673

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8094b2c
Improve contextual typing of partially annotated signatures
ahejlsberg Oct 17, 2016
808db07
Accept new baselines
ahejlsberg Oct 17, 2016
6425f0c
Fix lint error
ahejlsberg Oct 17, 2016
df58df1
Add partially annotated function tests
HerringtonDarkholme Oct 17, 2016
8aa56c1
Add fourslash test for contextually-typed `this`
sandersn Oct 17, 2016
af52b63
Address CR feedback
ahejlsberg Oct 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address CR feedback
  • Loading branch information
@ahejlsberg
ahejlsberg committed Oct 17, 2016
commit af52b6314c553195474ba11d38b4b952ef2f15fa
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6114,7 +6114,7 @@ namespace ts {
// know that all parameters (including 'this') have type annotations and nothing is
// subject to contextual typing.
const parameter = firstOrUndefined(node.parameters);
return !(parameter && parameter.name.kind === SyntaxKind.Identifier && (<Identifier>parameter.name).text === "this");
return !(parameter && parameterIsThisKeyword(parameter));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be written as !parameterIsThisKeyword(firstOrUndefined(node.parameters))

}

function isContextSensitiveFunctionOrObjectLiteralMethod(func: Node): func is FunctionExpression | ArrowFunction | MethodDeclaration {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy