-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Consistent errors on circular base types #39675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot test this |
Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 983ab3b. You can monitor the build here. |
Heya @ahejlsberg, I've started to run the extended test suite on this PR at 983ab3b. You can monitor the build here. |
Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 983ab3b. You can monitor the build here. |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Tests are clean (or preexisting conditions) except for one failure in interface DeviceFilter extends Partial<DeviceFilter> { } That clearly isn't right and it's definitely good that we're flagging it now. Not sure what the intent actually is. Any ideas for a fix? |
Honestly no idea what that's supposed to imply. The type extends the partial of itself? That's... Just trivially always true. Maybe just delete the constraint? |
Fixes #38098.