Skip to content

Consistent errors on circular base types #39675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Consistent errors on circular base types #39675

merged 3 commits into from
Jul 21, 2020

Conversation

ahejlsberg
Copy link
Member

Fixes #38098.

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jul 20, 2020
@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 20, 2020

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 983ab3b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 20, 2020

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 983ab3b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 20, 2020

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 983ab3b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

Tests are clean (or preexisting conditions) except for one failure in chrome-apps on Definitely Typed. This is the code:

interface DeviceFilter extends Partial<DeviceFilter> { }

That clearly isn't right and it's definitely good that we're flagging it now. Not sure what the intent actually is. Any ideas for a fix?

@ahejlsberg ahejlsberg merged commit 94d6b45 into master Jul 21, 2020
@ahejlsberg ahejlsberg deleted the fix38098 branch July 21, 2020 03:35
@weswigham
Copy link
Member

weswigham commented Jul 21, 2020

Honestly no idea what that's supposed to imply. The type extends the partial of itself? That's... Just trivially always true.

Maybe just delete the constraint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent recursive type allowed by Typescript
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy