Skip to content

Allowed tuples to have both named and anonymous members #53356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 26, 2023
Merged

Allowed tuples to have both named and anonymous members #53356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b7816ea
Allowed tuples to have both named and anonymous members
JoshuaKGoldberg Mar 19, 2023
2c316ce
What a fun little caching issue
JoshuaKGoldberg Mar 22, 2023
d246ce9
fix: it's any member being defined, not the array length
JoshuaKGoldberg Mar 23, 2023
c5efef9
Lint fix
JoshuaKGoldberg Mar 23, 2023
9859f6a
Switch to mapDefined, very nice
JoshuaKGoldberg Mar 23, 2023
99c4a01
Clear mapDefined result
JoshuaKGoldberg Mar 23, 2023
c3c2da3
More baselines
JoshuaKGoldberg Mar 26, 2023
c994d4b
Added ConditionalTuple test case
JoshuaKGoldberg Mar 26, 2023
31f493a
without ^?
JoshuaKGoldberg Mar 26, 2023
df397a7
accept baselines
JoshuaKGoldberg Mar 26, 2023
bf4b8cb
Keep partial labels in `createTupleTargetType`
Andarist Mar 27, 2023
3431d24
Merge pull request #3 from Andarist/keep-partial-labels-tuple-target-…
JoshuaKGoldberg Mar 27, 2023
796ec06
Remove redundant tests
JoshuaKGoldberg Mar 27, 2023
ffcfc79
Revert "Remove redundant tests"
JoshuaKGoldberg Mar 27, 2023
72ad400
ToMixedTuple again
JoshuaKGoldberg Mar 27, 2023
1e578a9
Expanded test case for reverse mapping
JoshuaKGoldberg Mar 28, 2023
6a7fdd1
Merge branch 'master'
JoshuaKGoldberg Jun 14, 2023
88eadca
Daniel Rosenwasser: Prettier as a Service
JoshuaKGoldberg Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ToMixedTuple again
  • Loading branch information
@JoshuaKGoldberg
JoshuaKGoldberg committed Mar 27, 2023
commit 72ad400525f6ccadc6da811d95b7f0d03cd4e908
6 changes: 3 additions & 3 deletions tests/baselines/reference/partiallyNamedTuples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ type ToMixedTuple<T extends unknown[]> = {
[K in keyof T]: [K, second: T[K], keyof T, fourth: T];
};

type AnonymousToMixed = ToAnonymousTuple<[boolean, number]>;
type MixedToMixed = ToAnonymousTuple<[boolean, second: number]>;
type NamedToMixed = ToAnonymousTuple<[first: boolean, second: number]>;
type AnonymousToMixed = ToMixedTuple<[boolean, number]>;
type MixedToMixed = ToMixedTuple<[boolean, second: number]>;
type NamedToMixed = ToMixedTuple<[first: boolean, second: number]>;

type MixedSpread = [first: boolean, ...[second: string]];

Expand Down
18 changes: 9 additions & 9 deletions tests/baselines/reference/partiallyNamedTuples.symbols
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,20 @@ type ToMixedTuple<T extends unknown[]> = {

};

type AnonymousToMixed = ToAnonymousTuple<[boolean, number]>;
type AnonymousToMixed = ToMixedTuple<[boolean, number]>;
>AnonymousToMixed : Symbol(AnonymousToMixed, Decl(partiallyNamedTuples.ts, 21, 2))
>ToAnonymousTuple : Symbol(ToAnonymousTuple, Decl(partiallyNamedTuples.ts, 9, 72))
>ToMixedTuple : Symbol(ToMixedTuple, Decl(partiallyNamedTuples.ts, 17, 75))

type MixedToMixed = ToAnonymousTuple<[boolean, second: number]>;
>MixedToMixed : Symbol(MixedToMixed, Decl(partiallyNamedTuples.ts, 23, 60))
>ToAnonymousTuple : Symbol(ToAnonymousTuple, Decl(partiallyNamedTuples.ts, 9, 72))
type MixedToMixed = ToMixedTuple<[boolean, second: number]>;
>MixedToMixed : Symbol(MixedToMixed, Decl(partiallyNamedTuples.ts, 23, 56))
>ToMixedTuple : Symbol(ToMixedTuple, Decl(partiallyNamedTuples.ts, 17, 75))

type NamedToMixed = ToAnonymousTuple<[first: boolean, second: number]>;
>NamedToMixed : Symbol(NamedToMixed, Decl(partiallyNamedTuples.ts, 24, 64))
>ToAnonymousTuple : Symbol(ToAnonymousTuple, Decl(partiallyNamedTuples.ts, 9, 72))
type NamedToMixed = ToMixedTuple<[first: boolean, second: number]>;
>NamedToMixed : Symbol(NamedToMixed, Decl(partiallyNamedTuples.ts, 24, 60))
>ToMixedTuple : Symbol(ToMixedTuple, Decl(partiallyNamedTuples.ts, 17, 75))

type MixedSpread = [first: boolean, ...[second: string]];
>MixedSpread : Symbol(MixedSpread, Decl(partiallyNamedTuples.ts, 25, 71))
>MixedSpread : Symbol(MixedSpread, Decl(partiallyNamedTuples.ts, 25, 67))

type ConditionalTuple = [
>ConditionalTuple : Symbol(ConditionalTuple, Decl(partiallyNamedTuples.ts, 27, 57))
Expand Down
12 changes: 6 additions & 6 deletions tests/baselines/reference/partiallyNamedTuples.types
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,14 @@ type ToMixedTuple<T extends unknown[]> = {
[K in keyof T]: [K, second: T[K], keyof T, fourth: T];
};

type AnonymousToMixed = ToAnonymousTuple<[boolean, number]>;
>AnonymousToMixed : [["0", boolean, keyof [boolean, number], [boolean, number]], ["1", number, keyof [boolean, number], [boolean, number]]]
type AnonymousToMixed = ToMixedTuple<[boolean, number]>;
>AnonymousToMixed : [["0", second: boolean, keyof [boolean, number], fourth: [boolean, number]], ["1", second: number, keyof [boolean, number], fourth: [boolean, number]]]

type MixedToMixed = ToAnonymousTuple<[boolean, second: number]>;
>MixedToMixed : [["0", boolean, keyof [boolean, second: number], [boolean, second: number]], second: ["1", number, keyof [boolean, second: number], [boolean, second: number]]]
type MixedToMixed = ToMixedTuple<[boolean, second: number]>;
>MixedToMixed : [["0", second: boolean, keyof [boolean, second: number], fourth: [boolean, second: number]], second: ["1", second: number, keyof [boolean, second: number], fourth: [boolean, second: number]]]

type NamedToMixed = ToAnonymousTuple<[first: boolean, second: number]>;
>NamedToMixed : [first: ["0", boolean, keyof [first: boolean, second: number], [first: boolean, second: number]], second: ["1", number, keyof [first: boolean, second: number], [first: boolean, second: number]]]
type NamedToMixed = ToMixedTuple<[first: boolean, second: number]>;
>NamedToMixed : [first: ["0", second: boolean, keyof [first: boolean, second: number], fourth: [first: boolean, second: number]], second: ["1", second: number, keyof [first: boolean, second: number], fourth: [first: boolean, second: number]]]

type MixedSpread = [first: boolean, ...[second: string]];
>MixedSpread : [first: boolean, second: string]
Expand Down
6 changes: 3 additions & 3 deletions tests/cases/conformance/types/tuple/named/partiallyNamedTuples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ type ToMixedTuple<T extends unknown[]> = {
[K in keyof T]: [K, second: T[K], keyof T, fourth: T];
};

type AnonymousToMixed = ToAnonymousTuple<[boolean, number]>;
type MixedToMixed = ToAnonymousTuple<[boolean, second: number]>;
type NamedToMixed = ToAnonymousTuple<[first: boolean, second: number]>;
type AnonymousToMixed = ToMixedTuple<[boolean, number]>;
type MixedToMixed = ToMixedTuple<[boolean, second: number]>;
type NamedToMixed = ToMixedTuple<[first: boolean, second: number]>;

type MixedSpread = [first: boolean, ...[second: string]];

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy