Don't inherit JSDocs from unrelated base properties onto constructor parameters with the same names #62077
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parameters with the same names
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where JSDoc comments from base class properties were incorrectly being inherited by constructor parameters that happened to have the same name. The fix ensures that JSDoc inheritance only occurs for constructor parameters that are actually property declarations (those with accessibility modifiers like public, private, or protected).
- Modifies the logic in
findBaseOfDeclarationto check for accessibility modifiers on constructor parameters - Adds a test case to verify that regular constructor parameters don't inherit JSDoc from unrelated base class properties
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/services/services.ts |
Updates JSDoc inheritance logic to only apply to constructor parameters with accessibility modifiers |
tests/cases/fourslash/jsDocDontInheritFromSameNamedPropertyOnParameter1.ts |
Adds test case verifying constructor parameters don't inherit unrelated JSDoc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #62069