Skip to content

Fix Windows_CI_GPU_DML_Dev_x86 and Windows_CI_GPU_DML_Dev_arm64 pipeline steps #24365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 18, 2025
Merged

Fix Windows_CI_GPU_DML_Dev_x86 and Windows_CI_GPU_DML_Dev_arm64 pipeline steps #24365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
576c5d4
Fix Windows_CI_GPU_DML_Dev_x86 and Windows_CI_GPU_DML_Dev_arm64 pipel…
amarin16 Apr 9, 2025
cb2ef94
use powershell for regex
amarin16 Apr 9, 2025
0290fa4
update x64 pipeline copy based on IsRelease
amarin16 Apr 11, 2025
35521fd
pipeline fix attempt
amarin16 Apr 14, 2025
67bf980
update powershell commands
amarin16 Apr 14, 2025
db963ee
update validation script
amarin16 Apr 15, 2025
12898f4
update validation script
amarin16 Apr 15, 2025
01eabf1
parse new argument
amarin16 Apr 15, 2025
135c6d7
fix attempt
amarin16 Apr 16, 2025
47bcf7b
fix attempt
amarin16 Apr 16, 2025
20aa628
fix attempt
amarin16 Apr 17, 2025
1a5466a
lint
amarin16 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tools/ci_build/github/azure-pipelines/c-api-noopenmp-packaging-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ stages:
DoEsrp: ${{ parameters.DoEsrp }}
NuPackScript: |
msbuild $(Build.SourcesDirectory)\csharp\OnnxRuntime.CSharp.proj /p:Configuration=RelWithDebInfo /t:CreatePackage /p:OrtPackageId=Microsoft.ML.OnnxRuntime.DirectML /p:IsReleaseBuild=${{ parameters.IsReleaseBuild }} /p:CurrentData=$(BuildDate) /p:CurrentTime=$(BuildTime)
copy $(Build.SourcesDirectory)\csharp\src\Microsoft.ML.OnnxRuntime\bin\RelWithDebInfo\*.nupkg $(Build.ArtifactStagingDirectory)
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\*.nupkg $(Build.ArtifactStagingDirectory)
copy $(Build.SourcesDirectory)\csharp\src\Microsoft.ML.OnnxRuntime\bin\RelWithDebInfo\Microsoft.ML.OnnxRuntime.DirectML.1.21.1.nupkg $(Build.ArtifactStagingDirectory)
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\Microsoft.ML.OnnxRuntime.DirectML.1.21.1.nupkg $(Build.ArtifactStagingDirectory)
mkdir $(Build.ArtifactStagingDirectory)\testdata
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\custom_op_library.* $(Build.ArtifactStagingDirectory)\testdata

Expand All @@ -169,7 +169,7 @@ stages:
NuPackScript: |
msbuild $(Build.SourcesDirectory)\csharp\OnnxRuntime.CSharp.proj /p:Configuration=RelWithDebInfo /p:TargetArchitecture=x86 /t:CreatePackage /p:OrtPackageId=Microsoft.ML.OnnxRuntime.DirectML /p:IsReleaseBuild=${{ parameters.IsReleaseBuild }}
cd $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\
ren Microsoft.ML.OnnxRuntime.DirectML.* win-dml-x86.zip
ren Microsoft.ML.OnnxRuntime.DirectML.1.21.1.nupkg win-dml-x86.zip
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\win-dml-x86.zip $(Build.ArtifactStagingDirectory)
mkdir $(Build.ArtifactStagingDirectory)\testdata
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\custom_op_library.* $(Build.ArtifactStagingDirectory)\testdata
Expand All @@ -191,7 +191,7 @@ stages:
NuPackScript: |
msbuild $(Build.SourcesDirectory)\csharp\OnnxRuntime.CSharp.proj /p:Configuration=RelWithDebInfo /p:TargetArchitecture=arm64 /t:CreatePackage /p:OrtPackageId=Microsoft.ML.OnnxRuntime.DirectML /p:IsReleaseBuild=${{ parameters.IsReleaseBuild }}
cd $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\
ren Microsoft.ML.OnnxRuntime.DirectML.* win-dml-arm64.zip
ren Microsoft.ML.OnnxRuntime.DirectML.1.21.1.nupkg win-dml-arm64.zip
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\win-dml-arm64.zip $(Build.ArtifactStagingDirectory)
mkdir $(Build.ArtifactStagingDirectory)\testdata
copy $(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo\custom_op_library.* $(Build.ArtifactStagingDirectory)\testdata
Expand Down Expand Up @@ -280,6 +280,7 @@ stages:
PackageName: 'Microsoft.ML.OnnxRuntime.DirectML*nupkg'
PlatformsSupported: 'win-x64,win-x86,win-arm64'
VerifyNugetSigning: ${{ parameters.DoEsrp }}
IsReleaseBuild: ${{ parameters.IsReleaseBuild }}

- task: PublishPipelineArtifact@0
displayName: 'Publish Pipeline NuGet Artifact'
Expand Down
3 changes: 2 additions & 1 deletion tools/ci_build/github/azure-pipelines/templates/validate-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ parameters:
PackageType: ''
PackageName: ''
PackagePath: ''
IsReleaseBuild: false
ScriptPath: '$(Build.SourcesDirectory)/tools/nuget/validate_package.py'
workingDirectory: "$(Build.BinariesDirectory)"

Expand All @@ -17,5 +18,5 @@ steps:
displayName: 'Validate Package'
inputs:
scriptPath: '${{parameters.ScriptPath}}'
arguments: '--package_type ${{parameters.PackageType}} --package_name ${{parameters.PackageName}} --package_path ${{parameters.PackagePath}} --platforms_supported ${{parameters.PlatformsSupported}} --verify_nuget_signing ${{parameters.VerifyNugetSigning}}'
arguments: '--package_type ${{parameters.PackageType}} --package_name ${{parameters.PackageName}} --package_path ${{parameters.PackagePath}} --platforms_supported ${{parameters.PlatformsSupported}} --verify_nuget_signing ${{parameters.VerifyNugetSigning}} --is_release_build ${{parameters.IsReleaseBuild}}'
workingDirectory: ${{parameters.workingDirectory}}
13 changes: 12 additions & 1 deletion tools/nuget/validate_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ def parse_arguments():
"--verify_nuget_signing",
help="Flag indicating if Nuget package signing is to be verified. Only accepts 'true' or 'false'",
)
parser.add_argument(
"--is_release_build",
help="Flag indicating if the script it should validate a release build or a dev one. Only accepts 'true' or 'false'",
)

return parser.parse_args()

Expand Down Expand Up @@ -285,7 +289,14 @@ def validate_zip(args):

def validate_nuget(args):
files = glob.glob(os.path.join(args.package_path, args.package_name))
nuget_packages_found_in_path = [i for i in files if i.endswith(".nupkg") and "Managed" not in i]
nuget_packages_found_in_path = [
i
for i in files
if i.endswith(".nupkg")
and "Managed" not in i
and ((args.is_release_build and "-dev" not in i) or (not args.is_release_build and "-dev" in i))
]

if len(nuget_packages_found_in_path) != 1:
print("Nuget packages found in path: ")
print(nuget_packages_found_in_path)
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy