Skip to content

chore: allow custom PLAYWRIGHT_BROWSERS_PATH with Pyinstaller #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2021
Merged

chore: allow custom PLAYWRIGHT_BROWSERS_PATH with Pyinstaller #1002

merged 2 commits into from
Nov 2, 2021

Conversation

mxschmitt
Copy link
Member

kumaraditya303
kumaraditya303 reviewed Nov 2, 2021
View reviewed changes
kumaraditya303
kumaraditya303 reviewed Nov 2, 2021
View reviewed changes
@mxschmitt @kumaraditya303
Apply suggestions from code review
3aaca69 
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@mxschmitt mxschmitt merged commit 0a3d7f0 into master Nov 2, 2021
@mxschmitt mxschmitt deleted the mxschmitt-patch-1 branch November 2, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Use different PLAYWRIGHT_BROWSERS_PATH when using Pyinstaller
2 participants
@mxschmitt @kumaraditya303
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy