Skip to content

feat(docs): validate doc parameters, report errors #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

feat(docs): validate doc parameters, report errors #104

merged 1 commit into from
Jul 29, 2020

Conversation

pavelfeldman
Copy link
Member

Validated and fixed some of the errors. Below is the list of outstanding issues. I did not verify types yet.

Not implemented parameter Frame.dblclick(noWaitAfter=)
Not documented parameters: Selectors.register(dict_keys(['path']))
Not documented parameters: Page.waitForRequest(dict_keys(['predicate']))
Not documented parameters: Page.waitForResponse(dict_keys(['predicate']))
Not implemented parameter Page.waitForEvent(optionsOrPredicate=)
Not documented parameters: Page.waitForEvent(dict_keys(['predicate', 'timeout']))
Not implemented parameter Page.setViewportSize(viewportSize=)
Not documented parameters: Page.setViewportSize(dict_keys(['width', 'height']))
Not implemented parameter Page.addInitScript(arg=)
Not documented parameters: Page.addInitScript(dict_keys(['path']))
Not implemented parameter Page.dblclick(noWaitAfter=)
Not implemented parameter BrowserContext.addInitScript(arg=)
Not documented parameters: BrowserContext.addInitScript(dict_keys(['path']))
Not implemented parameter BrowserContext.waitForEvent(optionsOrPredicate=)
Not documented parameters: BrowserContext.waitForEvent(dict_keys(['predicate', 'timeout']))
Not implemented parameter BrowserType.launch(firefoxUserPrefs=)
Not implemented parameter BrowserType.launch(logger=)
Not implemented parameter BrowserType.launchServer(firefoxUserPrefs=)
Not implemented parameter BrowserType.launchServer(logger=)
Not implemented parameter BrowserType.launchPersistentContext(chromiumSandbox=)
Not implemented parameter BrowserType.launchPersistentContext(logger=)
Not documented parameters: BrowserType.launchPersistentContext(dict_keys(['userDataDir']))
Not implemented parameter BrowserType.connect(logger=)

@coveralls
Copy link

coveralls commented Jul 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 186677618

  • 15 of 16 (93.75%) changed or added relevant lines in 6 files are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 86.98%
Changes Missing Coverage Covered Lines Changed/Added Lines %
playwright/sync_api.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
playwright/async_api.py 4 90.88%
playwright/sync_api.py 20 66.26%
Totals Coverage Status
Change from base Build 186248800: 0.0%
Covered Lines: 2866
Relevant Lines: 3295
💛 - Coveralls

@pavelfeldman pavelfeldman merged commit 0bb0e34 into microsoft:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @coveralls
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy