Skip to content

chore: explicit timeout config for send #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jun 24, 2025

Follow up from #2892. Remove implicit timeout information in server calls and make it explicit and required.

@agg23 agg23 requested a review from dgozman June 24, 2025 15:55
@agg23 agg23 force-pushed the explicit-timeout-config branch from 64e12e4 to 07834ba Compare June 24, 2025 18:18
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to annotate places that now have a timeout, but previously did not, but there are too many. Could you please align with Node.js to avoid behavior changes?

@agg23 agg23 merged commit 3713a32 into microsoft:main Jun 25, 2025
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy