Skip to content

tests: Simplify tests #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2021
Merged

tests: Simplify tests #558

merged 3 commits into from
Apr 16, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Mar 9, 2021 •
edited
Loading

Notable changes:

  • Use focal by default for CI
  • Test on Python 3.9
  • Convert reference counting script to a test
  • Convert installation test script to a test and test for all platforms not only for linux

@kumaraditya303 kumaraditya303 marked this pull request as draft March 13, 2021 08:16
@kumaraditya303 kumaraditya303 marked this pull request as ready for review March 14, 2021 10:20
kumaraditya303
kumaraditya303 commented Mar 14, 2021
View reviewed changes
pavelfeldman
pavelfeldman reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kumaraditya303
Copy link
Contributor Author

@pavelfeldman PR is rebased and ready to be merged

@pavelfeldman
Copy link
Member

There is a conflict...

@kumaraditya303
Copy link
Contributor Author

@mxschmitt I have rebased and, PR was already approved by @pavelfeldman so can you review this and merge ?

mxschmitt
mxschmitt approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats cool, waiting for bots to pass then we can land that.

@kumaraditya303
Copy link
Contributor Author

Seems they will pass but can wait sure

@mxschmitt mxschmitt merged commit 463c6df into microsoft:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@pavelfeldman pavelfeldman Awaiting requested review from pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @pavelfeldman @mxschmitt
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy