Skip to content

feat: firefox-stable channel #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

feat: firefox-stable channel #632

merged 2 commits into from
May 4, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 20, 2021 •
edited
Loading

kumaraditya303
kumaraditya303 commented Apr 20, 2021
View reviewed changes
Copy link
Contributor Author

@kumaraditya303 kumaraditya303 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed tests

pavelfeldman
pavelfeldman reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the stable channels bots downstream, upstream should be enough to cover it.

@pavelfeldman
Copy link
Member

This looks red all over!

@kumaraditya303
Copy link
Contributor Author

@pavelfeldman Failing tests are because docs are not added to upstream yet

mxschmitt
mxschmitt reviewed May 4, 2021
View reviewed changes
@mxschmitt mxschmitt merged commit c35ec2e into microsoft:master May 4, 2021
@kumaraditya303 kumaraditya303 deleted the feature/firefox-stable branch May 4, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@pavelfeldman pavelfeldman Awaiting requested review from pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @pavelfeldman @mxschmitt
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy