Skip to content

fix: recursively include packages for conda using setuptools #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

fix: recursively include packages for conda using setuptools #649

merged 1 commit into from
Apr 27, 2021

Conversation

kumaraditya303
Copy link
Contributor

No description provided.

mxschmitt
mxschmitt reviewed Apr 25, 2021
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either you use

find_packages(exclude=["tests*", "playwright._*"])

which will result in

['playwright', 'playwright.async_api', 'playwright.sync_api']

or you just hard-code the 3 output values of it. Having it like you suggested would result in

['playwright', 'tests.common', 'tests.async', 'tests.sync', 'playwright.async_api', 'playwright.sync_api', 'playwright._impl']

which is not expected from my understanding.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Apr 25, 2021 •
edited
Loading

Did you mean include instead of exclude ? We do need playwright._impl

@mxschmitt
Copy link
Member

Did you mean include instead of exclude ?

Just having packages=['playwright', 'playwright.async_api', 'playwright.sync_api'] as before and adding sync/async packages to the list which should result in the same and has less magic.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Apr 25, 2021 •
edited
Loading

packages=['playwright', 'playwright.async_api', 'playwright.sync_api'] do you want to hard code each value, in that case we do need _impl package

@mxschmitt
Copy link
Member

packages=['playwright', 'playwright.async_api', 'playwright.sync_api'] do you want to hard code each value, in that case we do need _impl package

ah I guessed impl was not expected there. 👍 Then feel free to adjust it to find_packages(exclude=["tests*"])

@mxschmitt mxschmitt requested a review from pavelfeldman April 25, 2021 12:43
@mxschmitt mxschmitt merged commit 890a833 into microsoft:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@pavelfeldman pavelfeldman Awaiting requested review from pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @mxschmitt
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy