Remove VITE_CALDERA_URL and use window.location.origin to route API requests #67
Conversation
Use window.location.origin to decide where to route API requests. VITE_CALDERA_URL added more complexity with little benefit
be9b3b9 to
afbc80a
Compare
|
Excellent changes! 🚀 |
|
I was able to confirm this fix by cloning these changes from @daw1012345 into my local @elegantmoose These changes will resolve a number of issues and discussions in the caldera repo and generally make the project much easier to work with. |
|
@djlawren are still fresh on previous changes to look at this one? |
|
@daw1012345 @rfulwell picking this up myself today .Appreciate your patience. |
|
@rfulwell @daw1012345 Were either of you able to test remote login on this PR? (ie logging in from system other than one Caldera is one) |
|
tested local login, works correctly. |
|
@rcamurphy tested remote login, works correctly. |
Use
window.location.originto decide where to route API requests.VITE_CALDERA_URL adds complexity with no clear benefit. It is very easy to misconfigure (especially when magma was built outside of container, the .env file was changed, and then the Docker container was built). When it is misconfigured, there is no error and the UI just seems unresponsive.
Due to CORS and tight coupling between caldera and magma, it is very unlikely that the URL is going to be anything other than the value held in
window.location.origin. In all other scenarios, a reverse proxy should be used.