Makefile: set BIND_DIR to "." by default #49957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it's needed to set `BIND_DIR=.` when starting the dev-container in order to bind-mount the current source-code into the container. Omitting that option only bind-mounts the "bundles" directory and copies the source into the image before starting. While there are some cases where (e.g.) a remote server is used for development, and bind-mounting is not possible, those scenarios should be considered more advanced, so let's make the common scenario easier to use. With this patch, running `make shell` should build and run the dev-container with the source-code mounted. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Looks like this one is still flaky (but perhaps waiting for one of the PRs to be merged); |
vvoland
approved these changes
May 27, 2025
|
Note to self; there's probably some contributing docs that need updating as well 🤔 - I'll try to open a PR for that if I think of it 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's needed to set
BIND_DIR=.when starting the dev-container in order to bind-mount the current source-code into the container. Omitting that option only bind-mounts the "bundles" directory and copies the source into the image before starting.While there are some cases where (e.g.) a remote server is used for development, and bind-mounting is not possible, those scenarios should be considered more advanced, so let's make the common scenario easier to use.
With this patch, running
make shellshould build and run the dev-container with the source-code mounted.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)