Skip to content

Add integration test for CSI plugins #49983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add integration test for CSI plugins #49983

wants to merge 1 commit into from

Conversation

olljanat
Copy link
Contributor

@olljanat olljanat commented May 14, 2025 •
edited
Loading

- What I did
Added integration test for CSI plugins.

- How I did it
Copied and modified from TestServicePlugin
Currently only one Swarm daemon is used but structure is already prepared in way that more nodes can be added if needed.

- How to verify it

- A picture of a cute animal (not mandatory but encouraged)
image

This was referenced May 14, 2025
Merged
Closed
thaJeztah
thaJeztah reviewed May 15, 2025
View reviewed changes
@olljanat olljanat force-pushed the csi-integration-test branch 2 times, most recently from c6cb7d8 to bf28163 Compare May 15, 2025 18:32
@olljanat
Copy link
Contributor Author

olljanat commented May 15, 2025 •
edited
Loading

It is expected CI to fail to timeout when looking for updated volume message from daemon log. That is because of bug #48133

Seems to work:

TestServicePlugin (27.22s)
=== RUN   TestServiceCSIPlugin
time="2025-05-15T18:57:56Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2025-05-15T18:57:56Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:91a9082541112724bb3f77b4654c2620bcfce7395f5a1a983cd72b421b0ee7e3" mediatype=application/vnd.docker.plugin.v1+json size=560
time="2025-05-15T18:57:56Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
time="2025-05-15T18:57:56Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:91a9082541112724bb3f77b4654c2620bcfce7395f5a1a983cd72b421b0ee7e3" mediatype=application/vnd.docker.plugin.v1+json size=560
    plugin_test.go:162: timeout hit after 15s: waiting for daemon logs match
--- FAIL: TestServiceCSIPlugin (20.09s)

EDIT: And seems to pass now when #49961 was merged 🥳

EDIT2: I figured out how to generate test data with CSI plugin and verify it's content from container so included that too so now it really is full end to end test.

@olljanat olljanat force-pushed the csi-integration-test branch from bf28163 to 45dc513 Compare May 15, 2025 19:36
@olljanat olljanat changed the title WIP: Add integration test for CSI plugins Add integration test for CSI plugins May 15, 2025
thaJeztah
thaJeztah reviewed May 16, 2025
View reviewed changes
@thaJeztah
Copy link
Member

@dperny PTAL

@olljanat olljanat force-pushed the csi-integration-test branch from 45dc513 to 0afd5ec Compare May 17, 2025 05:33
@olljanat olljanat mentioned this pull request May 17, 2025
Open
@olljanat olljanat force-pushed the csi-integration-test branch from 0afd5ec to 71c021a Compare May 19, 2025 18:06
@olljanat
Copy link
Contributor Author

Flaky tests in Moby, somehow I'm not surprised 🙈

Last update did hit:

which all looks unrelated. Will retrigger CI.

@olljanat olljanat force-pushed the csi-integration-test branch from 71c021a to 86a442e Compare May 19, 2025 19:02
@olljanat
Add integration test for CSI plugins
b4da545 
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
@olljanat olljanat force-pushed the csi-integration-test branch from 86a442e to b4da545 Compare May 21, 2025 06:06
@olljanat olljanat mentioned this pull request May 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/swarm area/testing area/volumes status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olljanat @thaJeztah @corhere
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy