builder-next: remove support for deprecated schema1 images #50036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
May 20, 2025
|
|
||
| stopProgress() | ||
| // similar to [github.com/docker/docker/distribution/DeprecatedSchema1ImageError] | ||
| return nil, cerrdefs.ErrInvalidArgument.WithMessage(errors.New("support for Docker Image Format v1 and Docker Image manifest version 2, schema 1 has been removed. More information at https://docs.docker.com/go/deprecated-image-specs/")) |
There was a problem hiding this comment.
Suggested change
| return nil, cerrdefs.ErrInvalidArgument.WithMessage(errors.New("support for Docker Image Format v1 and Docker Image manifest version 2, schema 1 has been removed. More information at https://docs.docker.com/go/deprecated-image-specs/")) | |
| return nil, cerrdefs.ErrInvalidArgument.WithMessage(errors.New("support for Docker Image Format v1 and Docker Image manifest version 2, schema 1 has been removed in Docker Engine v28.2. More information at https://docs.docker.com/go/deprecated-image-specs/")) |
There was a problem hiding this comment.
Ah, yes, can change.
Looks like I messed this up as well as I changed this last-minute 😂
builder/builder-next/adapters/containerimage/pull.go:524:55: cannot use errors.New("support for Docker Image Format v1 and Docker Image manifest version 2, schema 1 has been removed. More information at https://docs.docker.com/go/deprecated-image-specs/") (value of interface type error) as string value in argument to cerrdefs.ErrInvalidArgument.WithMessage
AkihiroSuda
approved these changes
May 20, 2025
the core/remotes/docker/schema1 package is deprecated and removed in containerd v2.1; remove its use as we already deprecated these images for "docker pull" and elsewhere. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
18b9f0e to
e8c2698
Compare
vvoland
approved these changes
May 21, 2025
dmcgowan
approved these changes
May 21, 2025
|
Let me bring this one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the core/remotes/docker/schema1 package is deprecated and removed in containerd v2.1; remove its use as we already deprecated these images for "docker pull" and elsewhere.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)