Skip to content

remove max message size #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

remove max message size #1105

merged 1 commit into from
Jul 8, 2025

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Jul 8, 2025

Removes the redundant MAXIMUM_MESSAGE_SIZE check from the HTTP transport layer. The validation was performed after loading the entire request body into memory, providing no actual memory protection.

Changes

  • Removed post-body-read size validation from _handle_post_request()

Rationale

  • Check executed after await request.body(), making it ineffective for memory exhaustion prevention
  • ASGI servers handle flow control via backpressure mechanisms
  • Simplifies codebase by removing ineffective validation

@ihrpr ihrpr requested a review from Kludex July 8, 2025 12:09
@Kludex
Copy link
Member

Kludex commented Jul 8, 2025

Thanks!

@ihrpr ihrpr merged commit beacd6e into main Jul 8, 2025
11 of 13 checks passed
@ihrpr ihrpr deleted the ihrpr/remove-max-message-size branch July 8, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy