feat: Update test suite to use latest Picotest #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d215f5f to
0b50b41
Compare
This commit updates the test infrastructure to be compatible with the latest Picotest framework from the picoruby submodule. Key changes include: - Modified to directly require gem. - Updated and to use for executing the test runner script, aligning with Picotest's execution model. - Adjusted for host tests to . - Added target to for comprehensive testing. - Fixed array literal syntax in .
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test suite to work with the latest Picotest framework sourced from the Picoruby submodule.
- Switched array literal syntax in a unit test to
%Wfor string arrays. - Updated the test runner script to require Picotest from the submodule and improved test execution commands.
- Added a
test_alltarget and unified various Makefile and CI steps to invoke Ruby directly.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| test/array_test.rb | Changed %() to %W() to ensure proper array-of-strings syntax. |
| test/0_runner.rb | Replaced require 'picotest' with explicit submodule path and added context comments. |
| Makefile | Introduced test_all target; updated platform test commands to use ruby runner and new config. |
| .github/workflows/test.yml | Cloned Picoruby submodule and switched CI test invocations to use ruby runner. |
Comments suppressed due to low confidence (2)
.github/workflows/test.yml:19
- [nitpick] Instead of a manual
git clone, consider usingactions/checkout@v4withsubmodules: recursiveto pull in the Picoruby submodule automatically.
- name: Clone PicoRuby
.github/workflows/test.yml:140
- [nitpick] This commented-out tmate configuration adds noise. Consider removing or moving it into a separate troubleshooting guide.
# - name: Setup tmate session
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the test infrastructure to be compatible with the latest Picotest framework from the picoruby submodule.
Key changes include: