Fix hashkey's inspect: "rocket" style to "colon" style #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `git clone --depth 1` in Dockerfile to speed up the build process by fetching only the latest commit. - Adjust the `require` path in `test/0_runner.rb` to correctly locate the `picotest` library, resolving a path issue in the test environment.
This commit updates the `Hash#inspect` method to produce output that is compatible with mruby, particularly in how it formats symbol keys. Key changes: - Modified `c_hash.c` to use the `key: value` syntax for symbol keys in `Hash#inspect`, aligning with modern Ruby conventions and mruby's output. - Updated `console.c` to handle the new symbol key formatting when printing hash objects. - Adjusted `symbol.c` to correctly inspect symbols that contain colons. - Updated related test cases in `array_test.rb` and `symbol_test.rb` to reflect the new `inspect` output. - Fixed a minor class name typo in `div_mod_test.rb`. Reference: mruby/mruby@baeeb5e
hasumikin
added a commit
to picoruby/mruby-compiler2
that referenced
this pull request
Jul 14, 2025
hasumikin
added a commit
to picoruby/picoruby
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to improve the handling of symbols, hash key formatting, and test coverage, as well as minor adjustments to the Dockerfile and test file paths. The most significant updates include enhancements to how symbols and hash keys are represented in
inspectmethods compatible with mruby, particularly in how it formats symbol keys.ref mruby/mruby@baeeb5e
Enhancements to symbol and hash key handling:
src/c_hash.c: Updatedc_hash_inspectto format hash keys differently based on their type (symbol or other types). Symbols are now displayed in a more concise format.src/console.c: Added a helper functionmrbc_p_sub_hashkeyto format hash keys consistently when printing hashes. Updatedmrbc_print_subto use this helper function [1] [2].src/symbol.c: Modifiedc_symbol_inspectto include quotes around symbols with colons, improving their readability.Updates to test cases:
test/array_test.rb: Adjusted expected outputs intest_inspectto reflect the updated formatting of hash keys and symbols.test/symbol_test.rb: Added a new test case for theinspectmethod to verify the formatting of symbols with colons.test/div_mod_test.rb: Renamed the test class fromSymbolTesttoDivModTestfor clarity.Dockerfile improvements:
Dockerfile: Changed thegit clonecommand to use--depth 1for a shallow clone, reducing download size. Updated defaultMRUBY_CONFIGtopicoruby-testfor consistency.Test file path adjustment:
test/0_runner.rb: Fixed the file path topicotestto ensure compatibility with the directory structure.