Migrate from JUnit 4 to JUnit 5 to resolve deprecation warnings #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update build.sbt to use JUnit 5 dependencies (jupiter + vintage) - Replace JUnit 4 imports with JUnit 5 equivalents - Convert @test(expected=Exception.class) to assertThrows() - Update @before to @beforeeach annotation - Replace deprecated org.junit.Assert.assertThat with Hamcrest assertThat - Maintain backward compatibility with JUnit Vintage engine Fixes all JUnit deprecation warnings in msgpack-jackson tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
build.sbtto use JUnit 5 Jupiter and Vintage engines@Test→@Test(JUnit 5)@Before→@BeforeEach@Test(expected=Exception.class)→assertThrows(Exception.class, () -> {...})org.junit.Assert.assertThatwithorg.hamcrest.MatcherAssert.assertThatTest Results
✅ All tests pass successfully
✅ No more JUnit deprecation warnings
✅ Compilation successful
Backward Compatibility
The JUnit Vintage engine is included to maintain compatibility with any remaining JUnit 4 tests.
🤖 Generated with Claude Code