Skip to content

Fix Jackson deprecation warnings in MessagePackFactory #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2025

Conversation

xerial
Copy link
Member

@xerial xerial commented Jul 19, 2025

Summary

  • Replace deprecated _createContext(Object, boolean) calls with _createContext(ContentReference, boolean)
  • Add missing import for ContentReference class
  • Eliminates deprecation warnings when running tests with Jackson 2.18.4

Test plan

  • Run sbt test and verify no Jackson deprecation warnings appear
  • Verify all existing tests continue to pass
  • Confirm Jackson module functionality remains unchanged

🤖 Generated with Claude Code

Replace deprecated _createContext(Object, boolean) calls with
_createContext(ContentReference, boolean) to eliminate warnings
when running tests with Jackson 2.18.4.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions bot added the bug label Jul 19, 2025
xerial and others added 2 commits July 19, 2025 11:26
Replace deprecated JsonParser methods with their current equivalents:
- getCurrentName() → currentName()
- getTokenLocation() → currentTokenLocation()
- getCurrentLocation() → currentLocation()

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Replace deprecated ParserMinimalBase constructor with StreamReadConstraints
- Add non-deprecated location methods (currentTokenLocation, currentLocation)
- Update GeneratorBase constructor to use 4-parameter form with IOContext and JsonWriteContext
- Add new createKeySerializer method signature for Jackson 2.18
- Keep deprecated methods for backward compatibility

All tests pass and Jackson deprecation warnings are eliminated.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@xerial xerial merged commit 799e2d1 into main Jul 19, 2025
9 checks passed
@xerial xerial deleted the fix-jackson-deprecation-warnings branch July 19, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy