Add missing null checks for njs_promise_create_function allocations #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
requested changes
May 15, 2025
There was a problem hiding this comment.
Hi @Nekrolm,
Thank you for contribution. The change looks good with minor changes needed.
Please, follow contribution guide in regards to commit log messages.
Suggested commit message: Added missing null checks in promise code.
Please, also, squash all the changes into a single commit. No merge commits.
385bc47 to
fa3a1bf
Compare
xeioex
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Hi!
I'm experimenting with memory pool limits for NJS and I've spotted 2 places where the result of
njs_promise_create_functioncall is dereferenced without proper checks. Causing segmentation fault on nullptr dereference.I'm not able to share minimal example -- it's hard to hit precisely these two lines via memory allocation failure.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument