Skip to content

Fixed segfault at error message in njs_property_query(). #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Fixed segfault at error message in njs_property_query(). #920

merged 1 commit into from
May 30, 2025

Conversation

VadimZhestikov
Copy link
Contributor

This closes #918 issue on Github.

@VadimZhestikov VadimZhestikov requested a review from xeioex May 28, 2025 16:20
xeioex
xeioex previously requested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@xeioex xeioex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For commit log it is good to add

Fixed segfault at error message in njs_property_query().

The issue was introduced in b28e50b1 (0.9.0). This closes #918 issue on Github.

xeioex
xeioex reviewed May 29, 2025
View reviewed changes
@VadimZhestikov VadimZhestikov force-pushed the seg_fault_at_err_msg branch from e885200 to 58dc560 Compare May 30, 2025 18:49
@VadimZhestikov VadimZhestikov changed the title Fixed segmentation fault at error message. Fixed segfault at error message in njs_property_query(). May 30, 2025
@VadimZhestikov VadimZhestikov requested a review from xeioex May 30, 2025 18:51
@VadimZhestikov VadimZhestikov dismissed xeioex’s stale review May 30, 2025 18:52

Applied suggestions

@VadimZhestikov
Fixed segfault at error message in njs_property_query().
bbb6b04 
The issue was introduced in b28e50b (0.9.0).
This closes nginx#918 issue on Github.
@VadimZhestikov VadimZhestikov force-pushed the seg_fault_at_err_msg branch from 58dc560 to bbb6b04 Compare May 30, 2025 19:08
xeioex
xeioex approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@xeioex xeioex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@VadimZhestikov VadimZhestikov merged commit f1aa752 into nginx:master May 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeioex xeioex xeioex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

njs_process_script_fuzzer: ASAN error in njs_vsprintf
2 participants
@VadimZhestikov @xeioex
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy