Skip to content

Fixed frame saving for awaited function with closures. #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2025

Conversation

xeioex
Copy link
Contributor

@xeioex xeioex commented Jun 12, 2025

No description provided.

@xeioex xeioex force-pushed the awaited_frame_saving_with_closures branch from 7207623 to df248d6 Compare June 12, 2025 05:44
@xeioex xeioex requested a review from VadimZhestikov June 12, 2025 05:44
Children functions need to be hoisted and instantiated at the beginning
of a function call. Previously, it was done as a part of C code
that implements JS function call.

Now, each child function is instantiated by FUNCTION instruction at a
function prelude. This makes global and function code similar, which in
turn allows to get rid of FUNCTION COPY instruction which was only
needed for global code.
@xeioex xeioex force-pushed the awaited_frame_saving_with_closures branch from df248d6 to b61e1d2 Compare June 14, 2025 03:22
VadimZhestikov
VadimZhestikov previously approved these changes Jun 16, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex force-pushed the awaited_frame_saving_with_closures branch from b61e1d2 to 05c7246 Compare June 16, 2025 23:44
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex merged commit 5431ea1 into nginx:master Jun 17, 2025
1 check passed
@xeioex xeioex deleted the awaited_frame_saving_with_closures branch June 17, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy