Skip to content

Fixed regexp compilation of patterns with escaped '[' characters. #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Fixed regexp compilation of patterns with escaped '[' characters. #936

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eca788
Modules: fixed qjs engine after bellard/quickjs@458c34d2.
xeioex Jul 2, 2025
29a2423
Fixed regexp compilation of patterns with escaped '[' characters.
xeioex Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Modules: fixed qjs engine after bellard/quickjs@458c34d2. 
Object leaks:
       ADDRESS REFS SHRF          PROTO CONTENT
0x512000007fc0    1 [module]
nginx: quickjs.c:1967: JS_FreeRuntime: Assertion `list_empty(&rt->gc_obj_list)' failed.

After bellard/quickjs@458c34d2 modules are treated as GC objects and
tracked in rt->gc_obj_list. Intermediary module object loaded in
ngx_qjs_clone() using JS_ReadObject() needed to be freed for proper
ref_count accounting.
  • Loading branch information
@xeioex
xeioex committed Jul 2, 2025
commit 7eca788aa3faecf2a11d2e037cb1a76d74e9b059
5 changes: 5 additions & 0 deletions nginx/ngx_js.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,11 @@ ngx_qjs_clone(ngx_js_ctx_t *ctx, ngx_js_loc_conf_t *cf, void *external)
"js load module exception: %V", &exception);
goto destroy;
}

if (i != length - 1) {
/* JS_EvalFunction() does JS_FreeValue(cx, rv) for the last rv. */
JS_FreeValue(cx, rv);
}
}

if (JS_ResolveModule(cx, rv) < 0) {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy