-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Update SSL policies, SSL Client certificates, Quic/HTTP3 #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, thanks for the PR. 👍
Could you add the new SSL policies to the docs ?
Could you elaborate on this ? I'm seeing more and more people having issues with http2 without really understanding why. Also this should be documented and, if possible, tested.
Same thing, those new features need doc update and tests, if it is actually possible to test them with our current CI. |
Good writeup on http2 issues: I personally had the issue from clients in china, having high rates of packet loss causing issues when I was using aws alb's and had to disable http2 on them. I'm not sure if quic/http3 can be tested, as it's not in the offical nginx build yet. I'll see what I can do about the rest. |
The CI rely on the
Things that still need to be added to the current PR:
Also, should HTTP/2 and HTTP/3 be mutually exclusive ? |
No you can run http/2 and http/3 at the same time. http/3 is the same deal as http/2, but runs over 443/udp, so it removes the issue with packet loss causing tcp to slow the connection down. There is an extra header on the http/1 http/2 response that tells the client if your http/3 enabled and what versions you support, so the client can switch over to it. |
That would require an additional port published on the proxy container like |
Ok, added documentation and I see nginx preview http3 release is using the http3 tag instead of quic tag to enable it, so I set that as the default. |
No problem, I'll take a look at how we could/should write a test for this and come back to you when I'll have something. In the meantime maybe we can merge this PR without the SSL client certificate feature and doc ? |
Pulled the client certificate code and docs |
@patrickdk77 with your approval I'm going to rebase the PR so when have a clean history prior to merge. Fell free to open another PR for client certificate verification. |
Ok I've given this a bit a more thought, I'm afraid that I'm not sure now is the time to start merging support for HTTP/3 if it is still so experimental that its isn't available in nginx yet. The aim of this image is to be based on and used with upstream nginx, not with experimental third party nginx images. |
Hey everyone, is it now possible to enable http3 Support with the "ENABLE_HTTP3=quic" tag at the enviroment section? thanks for the reply |
@patrickdk77 discussion about QUIC and HTTP/3 support : #2271 |
Adds newer SSL policies
Adds SSL Client certificate support for verification and passthough
Adds quic/http3 configuration support
Makes http2 optional (packet loss makes http2 unusable)
Fix leftover port 80 definition with external_http_port definition