-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Save gifti with datatype None #4857
Conversation
👋 @man-shu Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4857 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 137 137
Lines 17133 17134 +1
Branches 2948 2948
=======================================
+ Hits 16052 16054 +2
Misses 573 573
+ Partials 508 507 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I’m testing this on s390x. I should be able to report results tomorrow morning. |
I tried this as a patch to 0.11.0, and it does not seem to have made a difference in the failing tests on |
Stop the presses! I’m mistaken. The patch wasn’t actually applied. I need to try it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test is needed on this PR.
This does work in my testing! All of the tests that regressed in #4855 pass when I properly apply this PR as a patch for 0.11.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Changes proposed in this pull request: