-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] refactor group_sparse_covariance #4899
Conversation
suffix = f" variation (max norm): {max_norm:.3e} " | ||
else: | ||
suffix = "" | ||
if verbose > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this if block can be removed as the log function will directly handle the verbose level
np.dot(W[..., k], W_inv[..., k]), | ||
np.eye(W_inv[..., k].shape[0]), | ||
decimal=10, | ||
) | ||
if debug: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a lot of those debug statement that in my opinion should not be there
once more of this code has been refactored it may be easier to replace them with proper tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4899 +/- ##
==========================================
+ Coverage 93.69% 93.72% +0.03%
==========================================
Files 137 137
Lines 17133 17146 +13
Branches 2948 2946 -2
==========================================
+ Hits 16052 16070 +18
+ Misses 573 569 -4
+ Partials 508 507 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for looking at that one.
np.dot(W[..., k], W_inv[..., k]), | ||
np.eye(W_inv[..., k].shape[0]), | ||
decimal=10, | ||
) | ||
if debug: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found a typo, otherwise LGTM!
Co-authored-by: Himanshu Aggarwal <himanshuaggarwal1997@gmail.com>
Changes proposed in this pull request: