Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] remove some checks for matplotlib we no longer support #4936

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Dec 11, 2024

Changes proposed in this pull request:

  • remove checks related to some old mpl versions
  • modify an example to 'test'

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (c8149fe) to head (ec82376).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4936      +/-   ##
==========================================
+ Coverage   93.76%   93.77%   +0.01%     
==========================================
  Files         137      137              
  Lines       17151    17149       -2     
  Branches     2946     2944       -2     
==========================================
  Hits        16082    16082              
  Misses        563      563              
+ Partials      506      504       -2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
macos-latest_3.11_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
macos-latest_3.12_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
macos-latest_3.13_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
macos-latest_3.9_test_plotting 93.29% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.10_test_plotting 93.31% <100.00%> (+<0.01%) ⬆️
ubuntu-latest_3.11_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.12_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.13_test_plotting 93.31% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.13_test_pre 93.31% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.9_test_min 69.55% <0.00%> (+<0.01%) ⬆️
ubuntu-latest_3.9_test_plot_min 92.17% <100.00%> (+0.01%) ⬆️
ubuntu-latest_3.9_test_plotting 93.29% <100.00%> (+0.01%) ⬆️
windows-latest_3.10_test_plotting 93.29% <100.00%> (+0.01%) ⬆️
windows-latest_3.11_test_plotting 93.29% <100.00%> (+0.01%) ⬆️
windows-latest_3.12_test_plotting 93.29% <100.00%> (+0.01%) ⬆️
windows-latest_3.13_test_plotting 93.29% <100.00%> (+0.01%) ⬆️
windows-latest_3.9_test_plotting 93.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean that the checks are no longer needed for the mpl versions we support ?
If yes, then we're good.

@Remi-Gau
Copy link
Collaborator Author

You mean that the checks are no longer needed for the mpl versions we support ? If yes, then we're good.

yup that's I meant
sorry
I was unclear

@Remi-Gau Remi-Gau changed the title [MAINT] remove if blocks for matplotlib deprecations [MAINT] remove some checks for matplotlib we no longer support Dec 11, 2024
@Remi-Gau Remi-Gau marked this pull request as ready for review December 11, 2024 17:04
@Remi-Gau Remi-Gau merged commit 9850697 into nilearn:main Dec 11, 2024
32 of 33 checks passed
@Remi-Gau Remi-Gau deleted the fix/4934 branch December 11, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

simplify colormap definition for colormaps that exist in matplolib 3.3.0
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy