Make sure that multiple setModuleDefaults calls update the config sources properly #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config and the sources being consistent with each other.
|
I'd like us to sort out the setModuleDefaults issue. I think I may have a solution we could to in Util to keep the defaults and the loaded config as two separate pieces of data and do the heavy lifting in setModuleDefaults so that it's a zero cost abstraction if nobody is using this feature. Since it's a startup only operation I'm a little less concerned about the perf. Plus I just landed some perf improvements anyway. I have another idea for fixing it but it might introduce a circular dependency so I need to think on it more: |
markstos
approved these changes
Jun 3, 2025
This was referenced Jun 12, 2025
|
@markstos So I think we are probably ready for 4.0.1 |
|
4.0.1 is OK with me. |
|
this conflicts a bit with a PR for #822 which also happens to fix this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this constitutes a breaking change. I don't know if anyone is relying on configSources for programmatic behavior.
Abundance of caution says yes.
fixes #827