src: improve parsing of boolean options

geeksilva97 · RafaelGSS · commit 130eaa20a489 · 2025-05-02T17:06:59.000-03:00
PR-URL: #58039 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node_config_file.cc b/src/node_config_file.cc
@@ -59,8 +59,12 @@ ParseResult ConfigReader::ParseNodeOptions(
             FPrintF(stderr, "Invalid value for %s\n", it->first.c_str());
             return ParseResult::InvalidContent;
           }
-          node_options_.push_back(it->first + "=" +
-                                  (result ? "true" : "false"));
+
+          if (result) {
+            // If the value is true, we need to set the flag
+            node_options_.push_back(it->first);
+          }
+
           break;
         }
         // String array can allow both string and array types
diff --git a/test/fixtures/rc/inspect-false.json b/test/fixtures/rc/inspect-false.json
@@ -0,0 +1,5 @@
+{
+  "nodeOptions": {
+    "inspect": false
+  }
+}
diff --git a/test/fixtures/rc/inspect-true.json b/test/fixtures/rc/inspect-true.json
@@ -0,0 +1,5 @@
+{
+  "nodeOptions": {
+    "inspect": true
+  }
+}
diff --git a/test/parallel/test-config-file.js b/test/parallel/test-config-file.js
@@ -232,6 +232,30 @@ test('host port flag should be parsed correctly', { skip: !process.features.insp
   strictEqual(result.code, 0);
 });
 
+test('--inspect=true should be parsed correctly', { skip: !process.features.inspector }, async () => {
+  const result = await spawnPromisified(process.execPath, [
+    '--no-warnings',
+    '--experimental-config-file',
+    fixtures.path('rc/inspect-true.json'),
+    '-p', 'require("node:inspector").url()',
+  ]);
+  match(result.stderr, /^Debugger listening on (ws:\/\/[^\s]+)/);
+  match(result.stdout, /ws:\/\/[^\s]+/);
+  strictEqual(result.code, 0);
+});
+
+test('--inspect=false should be parsed correctly', { skip: !process.features.inspector }, async () => {
+  const result = await spawnPromisified(process.execPath, [
+    '--no-warnings',
+    '--experimental-config-file',
+    fixtures.path('rc/inspect-false.json'),
+    '-p', 'require("node:inspector").url()',
+  ]);
+  strictEqual(result.stderr, '');
+  strictEqual(result.stdout, 'undefined\n');
+  strictEqual(result.code, 0);
+});
+
 test('no op flag should throw', async () => {
   const result = await spawnPromisified(process.execPath, [
     '--no-warnings',

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +  "nodeOptions": {
 +    "inspect": false
 +  }
 +}