tools: fix bug in prefer-primordials lint rule

aduh95 · danielleadams · commit 665b7424ebe7 · 2023-04-03T07:49:38.000-04:00
PR-URL: #46659 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-eslint-prefer-primordials.js b/test/parallel/test-eslint-prefer-primordials.js
@@ -57,7 +57,9 @@ new RuleTester({
       {
         code: `
           const { ObjectDefineProperty, Symbol } = primordials;
-          ObjectDefineProperty(o, Symbol.toStringTag, { value: "o" })
+          ObjectDefineProperty(o, Symbol.toStringTag, { value: "o" });
+          const val = Symbol.toStringTag;
+          const { toStringTag } = Symbol;
         `,
         options: [{ name: 'Symbol', ignore: ['toStringTag'] }]
       },
diff --git a/tools/eslint-rules/prefer-primordials.js b/tools/eslint-rules/prefer-primordials.js
@@ -114,7 +114,7 @@ module.exports = {
           node,
         );
         const parentName = parent?.name;
-        if (!isTarget(nameMap, name) && !isTarget(nameMap, parentName)) {
+        if (!isTarget(nameMap, name) && (!isTarget(nameMap, parentName) || isIgnored(nameMap, parentName, name))) {
           return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ module.exports = {`
`114`	`114`	`node,`
`115`	`115`	`);`
`116`	`116`	`const parentName = parent?.name;`
`117`		`- if (!isTarget(nameMap, name) && !isTarget(nameMap, parentName)) {`
	`117`	`+ if (!isTarget(nameMap, name) && (!isTarget(nameMap, parentName) \|\| isIgnored(nameMap, parentName, name))) {`
`118`	`118`	`return;`
`119`	`119`	`}`
`120`	`120`