src: do not track BaseObjects directly in Realm

joyeecheung · danielleadams · commit 88baf98fa349 · 2023-04-10T20:55:05.000-04:00
They are referenced through the CleanupQueue which is already tracked. Tracking them again in Realms results in duplicates in the heap snapshot. PR-URL: #46470 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
diff --git a/src/node_realm.cc b/src/node_realm.cc
@@ -47,12 +47,6 @@ void Realm::MemoryInfo(MemoryTracker* tracker) const {
 
   tracker->TrackField("env", env_);
   tracker->TrackField("cleanup_queue", cleanup_queue_);
-
-  ForEachBaseObject([&](BaseObject* obj) {
-    if (obj->IsDoneInitializing()) {
-      tracker->Track(obj);
-    }
-  });
 }
 
 void Realm::CreateProperties() {
